Skip to content

CCM-9353: Refactor Assertions Class#1005

Merged
Kennedy1265 merged 19 commits into
releasefrom
feature/ccm-9353
Oct 8, 2025
Merged

CCM-9353: Refactor Assertions Class#1005
Kennedy1265 merged 19 commits into
releasefrom
feature/ccm-9353

Conversation

@Kennedy1265
Copy link
Copy Markdown
Contributor

@Kennedy1265 Kennedy1265 commented Sep 29, 2025 •
edited
Loading

Summary

  • Split out assertions class by endpoint
  • Create functions for each attribute to assert against
  • Add additional format assertions

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

8 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

Ian-Hodges
Ian-Hodges reviewed Oct 2, 2025
View reviewed changes
Comment thread scripts/config/sonar-scanner.properties Outdated
Ian-Hodges
Ian-Hodges previously approved these changes Oct 2, 2025
View reviewed changes
gareth-allan
gareth-allan reviewed Oct 2, 2025
View reviewed changes
Comment thread sandbox/messages/2WL3qFTEFM0qMY8xjRbt1LIKCzM.json Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

gareth-allan
gareth-allan reviewed Oct 7, 2025
View reviewed changes
Comment thread tests/lib/assertions/message_batches.py Outdated
Comment thread tests/lib/assertions/nhsapp_accounts.py Outdated
Comment thread tests/lib/assertions/assertions.py
Comment thread tests/lib/assertions/get_message.py
Comment thread tests/lib/assertions/assertions.py
@Kennedy1265 Kennedy1265 added the python Pull requests that update Python code label Oct 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

gareth-allan
gareth-allan reviewed Oct 8, 2025
View reviewed changes
Comment thread .tool-versions Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-9353

@Kennedy1265 Kennedy1265 requested a review from Ian-Hodges October 8, 2025 15:15
@Kennedy1265 Kennedy1265 merged commit e045f89 into release Oct 8, 2025
11 of 14 checks passed
@Kennedy1265 Kennedy1265 deleted the feature/ccm-9353 branch October 8, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ian-Hodges Ian-Hodges Ian-Hodges approved these changes

@gareth-allan gareth-allan gareth-allan approved these changes

Assignees

No one assigned

Labels

python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kennedy1265 @Ian-Hodges @gareth-allan